Debugging Groups Module Integration Tests#67
Merged
bpolania merged 2 commits intoandrew/add-group-modulefrom Apr 23, 2025
Merged
Debugging Groups Module Integration Tests#67bpolania merged 2 commits intoandrew/add-group-modulefrom
bpolania merged 2 commits intoandrew/add-group-modulefrom
Conversation
bpolania
requested review from
DracoLi,
aandrewchung,
edisonz0718 and
sebsadface
as code owners
DracoLi
approved these changes
Apr 22, 2025
| token_id=token_id | ||
| ) | ||
| ip_id = register_response['ipId'] | ||
| print(register_response) |
Contributor
There was a problem hiding this comment.
Suggested change
| print(register_response) |
aandrewchung
added a commit
that referenced
this pull request
Apr 24, 2025
* Added auto generated python classes for group module * Added EVEN_SPLIT_GROUP_POOL constant to utils for integration test * Added group module to story client * Added register_group() to group module * Added royalty policy lrp constant for integration test * Added register_group_and_attach_license() * Updated abis for grouping module and workflows * buggy mint_and_register_ip_and_attach_license_and_add_to_group() * Added register_group_and_attach_license_and_add_ips() and respective integration test * Added mint_and_register_ip_and_attach_license_and_add_to_group() and respective integration test * Added transfer_to_vault() to royalty module * testing collect_and_distribute_group_royalties() * Updated abi jsons * Updating setLicensingConfig() func * Updated get_permission_signature for multiple permissions * Added register_ip_and_attach_license_and_add_to_group() to group module * collect_and_distribute_group_royalties() bug * uncommented integration tests for test_register_group_and_attach_license_and_add_ips() * Updated transfer_to_vault() to use LRP abi * Debugging Groups Module Integration Tests (#67) * Debugging * Update test_integration_ip_account.py * Update test_integration_ip_account.py * Update test_integration_nft_client.py * Update test_integration_ip_account.py * Addressed self.web3 vs Web3 cmnt * Updated parse fns to raise error instead of returning none * fix CORE_METADATA_MODULE issue (#71) --------- Co-authored-by: Boris Polania <boris.polania@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the following issues:
collect_and_distribute_group_royaltiescall. These were caused by the use of a incorrect version of theCollectedRoyaltiesToGroupPoolandRoyaltyPaidevents signatures in theGroupmodule.